[TW-5592] Support callback URIs in application updates#737
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 42 42
Lines 1006 1006
Branches 90 90
=======================================
Hits 995 995
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
AaronDDM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to the review feedback on nylas-java#327.
PATCH /v3/applicationsacceptscallback_uris, and callers need to include an existing callback URIidwhen preserving or updating entries. The Node SDK typed request model did not expose that shape.Summary
UpdateApplicationRedirectUriRequestwith optionalid,platform, andsettings.callbackUristoUpdateApplicationRequestand remove stale docs saying callback URIs are ignored.callbackUrisentry with an existingidin the application update test.invalidAlsoworkspace auto-group support.Testing
npm test -- --coverage=false tests/resources/applications.spec.tsnpm run lint:prettier:checknpx tsc -p tsconfig.esm.json --noEmitnpx tsc -p tsconfig.cjs.json --noEmit